Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-3788] chore: file support design qa #357

Merged
merged 9 commits into from
Sep 11, 2024
Merged

[AC-3788] chore: file support design qa #357

merged 9 commits into from
Sep 11, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Sep 11, 2024 •
edited by jira bot
Loading

Changes

  • Design QA changes

ticket: AC-3788

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Size Change: +7.75 kB (+1.31%)

Total Size: 602 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB +2 B (+0.05%)
./dist/__bundle-91b5ecea-********.js 0 B -889 B (removed) 🏆
./dist/index-********.js 305 kB +3.88 kB (+1.29%)
./dist/index.es.js 173 B +3 B (+1.76%)
./dist/index.umd.js 282 kB +3.46 kB (+1.24%)
./dist/Placeholder.error-********.js 345 B -1 B (-0.29%)
./dist/Placeholder.loading-********.js 184 B -160 B (-46.51%) 🎉
./dist/Placeholder.noChannels-********.js 184 B +2 B (+1.1%)
./dist/Placeholder.noMessages-********.js 184 B +2 B (+1.1%)
./dist/PlaceholderCommon-********.js 246 B -1 B (-0.4%)
./dist/style.css 8.64 kB +568 B (+7.04%) 🔍
./dist/__bundle-bbedc09c-********.js 891 B +891 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B

compressed-size-action

liamcho
liamcho approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bang9 bang9 changed the title Feat/file support design qa chore: file support design qa Sep 11, 2024
@bang9 bang9 changed the base branch from feat/file-support to develop September 11, 2024 05:36
@bang9 bang9 force-pushed the feat/file-support-design-qa branch from 6326a71 to 5aa8d9b Compare September 11, 2024 05:36
@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 0f59c11
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/66e166c8280eb40009f1576e
😎 Deploy Preview https://deploy-preview-357--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bang9 bang9 force-pushed the feat/file-support-design-qa branch 2 times, most recently from 8219ffc to 43f331f Compare September 11, 2024 08:31
@bang9 bang9 changed the title chore: file support design qa [AC-3788] chore: file support design qa Sep 11, 2024
@bang9 bang9 self-assigned this Sep 11, 2024
@bang9 bang9 force-pushed the feat/file-support-design-qa branch from 032c6c3 to 0f59c11 Compare September 11, 2024 09:45
@bang9 bang9 changed the base branch from develop to feat/file-support September 11, 2024 09:46
@bang9 bang9 merged commit 4f5a809 into feat/file-support Sep 11, 2024
7 of 10 checks passed
@bang9 bang9 deleted the feat/file-support-design-qa branch September 11, 2024 09:47
@bang9 bang9 added the 1.8.0 label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamcho liamcho liamcho approved these changes

Assignees

@bang9 bang9

Labels
1.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bang9 @liamcho